diff --git a/src/locales/lang/zh-CN.ts b/src/locales/lang/zh-CN.ts
index 3e5ec17..837c9ca 100644
--- a/src/locales/lang/zh-CN.ts
+++ b/src/locales/lang/zh-CN.ts
@@ -63,6 +63,7 @@ export default {
     success: '提交成功',
     fail: '提交失败',
     saveSuccess: '保存成功',
+    editSuccess: '修改成功',
     deleteSuccess: '删除成功',
     saveFail: '保存失败',
     emptyData: '暂无数据',
diff --git a/src/pages/system/menus/components/MenuTree.tsx b/src/pages/system/menus/components/MenuTree.tsx
index d5bb025..d79d638 100644
--- a/src/pages/system/menus/components/MenuTree.tsx
+++ b/src/pages/system/menus/components/MenuTree.tsx
@@ -36,6 +36,7 @@ const MenuTree = ({ form }: { form: FormInstance }) => {
 
     return () => {
       setCurrentMenu({} as MenuItem)
+      setIds([])
     }
 
   }, [ data, isLoading ])
diff --git a/src/pages/system/menus/index.tsx b/src/pages/system/menus/index.tsx
index 534ae77..39389e5 100644
--- a/src/pages/system/menus/index.tsx
+++ b/src/pages/system/menus/index.tsx
@@ -33,7 +33,6 @@ const Menus = () => {
         description: (error as any).message ?? t('message.saveFail', '保存失败'),
       })
     }
-
   }, [ isError, isSuccess ])
 
   return (
diff --git a/src/pages/system/menus/store.ts b/src/pages/system/menus/store.ts
index c06c7ea..5a32a6d 100644
--- a/src/pages/system/menus/store.ts
+++ b/src/pages/system/menus/store.ts
@@ -60,7 +60,8 @@ export const saveOrUpdateMenuAtom = atomWithMutation<IApiResult<IMenu>>((get) =>
             return await systemServ.menus.update(data)
         },
         onSuccess: (res) => {
-            message.success(t('message.saveSuccess', '保存成功'))
+            const isAdd = !!res.data?.id
+            message.success(t( isAdd ? 'message.saveSuccess': 'message.editSuccess', '保存成功'))
             const menu = get(selectedMenuAtom)
             store.set(selectedMenuAtom, {
                 ...menu,
@@ -69,7 +70,7 @@ export const saveOrUpdateMenuAtom = atomWithMutation<IApiResult<IMenu>>((get) =>
             //更新列表
             // eslint-disable-next-line @typescript-eslint/ban-ts-comment
             // @ts-ignore fix
-            get(queryClientAtom).refetchQueries([ 'menus', get(menuPageAtom) ]).then()
+            get(queryClientAtom).invalidateQueries([ 'menus', get(menuPageAtom) ]).then()
         }
     }
 })
@@ -85,7 +86,7 @@ export const deleteMenuAtom = atomWithMutation((get) => {
         onSuccess: () => {
             message.success(t('message.deleteSuccess', '删除成功'))
             store.set(batchIdsAtom, [])
-            get(queryClientAtom).refetchQueries([ 'menus', get(menuPageAtom) ]).then()
+            get(queryClientAtom).invalidateQueries([ 'menus', get(menuPageAtom) ]).then()
         }
     }
 })
\ No newline at end of file
diff --git a/src/pages/system/roles/index.tsx b/src/pages/system/roles/index.tsx
index 0344fe8..b34dbdd 100644
--- a/src/pages/system/roles/index.tsx
+++ b/src/pages/system/roles/index.tsx
@@ -1,33 +1,89 @@
-import { ActionType, PageContainer, ProColumns, ProTable,BetaSchemaForm } from '@ant-design/pro-components'
+import {
+    ActionType,
+    PageContainer,
+    ProColumns,
+    ProTable,
+    BetaSchemaForm,
+} from '@ant-design/pro-components'
 import { createLazyFileRoute } from '@tanstack/react-router'
 import { useStyle } from './style.ts'
-import { useMemo, useRef, useState } from 'react'
-import { useAtom, useAtomValue } from 'jotai'
-import { roleAtom, rolesAtom } from './store.ts'
+import { useEffect, useMemo, useRef, useState } from 'react'
+import { useAtom, useAtomValue, useSetAtom } from 'jotai'
+import { pageAtom, roleAtom, rolesAtom, saveOrUpdateRoleAtom, searchAtom } from './store.ts'
 import { useTranslation } from '@/i18n.ts'
-import { Button, Form, Space, Table } from 'antd'
+import { Button, Form, Space, Spin, Table, Tree } from 'antd'
 import { PlusOutlined } from '@ant-design/icons'
+import { menuDataAtom } from '@/pages/system/menus/store.ts'
+import { getTreeCheckedStatus } from '@/utils/tree.ts'
+
+const MenuTree = (props: any) => {
+    const { data: menuList, isLoading: menuLoading } = useAtomValue(menuDataAtom)
+    const { value, onChange, form, id, mode } = props
+
+    const onCheck = (checkedKeys: any, info: any) => {
+        if (onChange) {
+            onChange([ ...checkedKeys, ...info.halfCheckedKeys ])
+        } else {
+            form.setFieldsValue({ [id]: [ ...checkedKeys, ...info.halfCheckedKeys ] })
+        }
+    }
+    if (menuLoading) {
+        return <Spin spinning={true} size={'small'}/>
+    }
+    return <Tree treeData={menuList}
+                 fieldNames={{ title: 'title', key: 'id' }}
+                 disabled={mode !== 'edit'} checkable={true} onCheck={onCheck}
+                 checkedKeys={getTreeCheckedStatus(menuList, value)}/>
+
+
+}
 
 const Roles = () => {
 
     const { t } = useTranslation()
     const { styles } = useStyle()
-    const [form] = Form.useForm()
+    const [ form ] = Form.useForm()
     const actionRef = useRef<ActionType>()
-    const { data, isLoading } = useAtomValue(rolesAtom)
-    const [ role, setRole ] = useAtom(roleAtom)
-    const [ open, setOpen] = useState(false)
+    const [ page, setPage ] = useAtom(pageAtom)
+    const setSearch = useSetAtom(searchAtom)
+    const { data, isLoading, isFetching, refetch } = useAtomValue(rolesAtom)
+    const { isPending, mutate, isSuccess } = useAtomValue(saveOrUpdateRoleAtom)
+    const [ , setRole ] = useAtom(roleAtom)
+    const [ open, setOpen ] = useState(false)
 
     const columns = useMemo(() => {
 
         return [
-            { title: 'id', dataIndex: 'id', hideInTable: true, hideInSearch: true, hideInForm: true,},
-            { title: '名称', dataIndex: 'name', valueType: 'text',},
-            { title: '别名', dataIndex: 'code', valueType: 'text', },
+            {
+                title: 'id', dataIndex: 'id',
+                hideInTable: true,
+                hideInSearch: true,
+                // hideInForm: true,
+            },
+            {
+                title: '名称', dataIndex: 'name', valueType: 'text',
+                formItemProps: {
+                    rules: [ { required: true, message: '请输入角色名称' } ]
+                }
+            },
+            {
+                title: '别名', dataIndex: 'code', valueType: 'text',
+                formItemProps: {
+                    rules: [ { required: true, message: '请输入别名' } ]
+                }
+            },
             { title: '状态', dataIndex: 'status', valueType: 'switch', },
-            { title: '排序', dataIndex: 'sort', valueType: 'indexBorder', },
-            { title: '备注', dataIndex: 'remark' ,valueType: 'textarea' },
-            { title: '权限', dataIndex: 'permissions', valueType: 'treeSelect', },
+            {
+                title: '排序', dataIndex: 'sort', valueType: 'digit',
+            },
+            { title: '备注', dataIndex: 'description', valueType: 'textarea' },
+            {
+                title: '权限', dataIndex: 'menu_ids',
+                valueType: 'text',
+                renderFormItem: (item, config, form) => {
+                    return <MenuTree {...config} form={form} {...item.fieldProps} />
+                }
+            },
             {
                 title: '操作', valueType: 'option',
                 key: 'option',
@@ -35,7 +91,6 @@ const Roles = () => {
                     <a
                             key="editable"
                             onClick={() => {
-                                // action?.startEditable?.(record.id)
                                 setRole(record)
                                 setOpen(true)
                                 form.setFieldsValue(record)
@@ -51,6 +106,12 @@ const Roles = () => {
         ] as ProColumns[]
     }, [])
 
+    useEffect(() => {
+        if (isSuccess) {
+            setOpen(false)
+        }
+    }, [ isSuccess ])
+
     return (
             <PageContainer breadcrumbRender={false} title={false} className={styles.container}>
                 <ProTable
@@ -58,35 +119,40 @@ const Roles = () => {
                         actionRef={actionRef}
                         headerTitle={t('system.roles.title', '角色管理')}
                         columns={columns}
-                        loading={isLoading}
+                        loading={isLoading || isFetching}
                         dataSource={data?.rows}
                         search={false}
                         rowSelection={{
-                            selections: [Table.SELECTION_ALL, Table.SELECTION_INVERT],
+                            selections: [ Table.SELECTION_ALL, Table.SELECTION_INVERT ],
                         }}
                         tableAlertOptionRender={() => {
                             return (
                                     <Space size={16}>
                                         <a>批量删除</a>
                                     </Space>
-                            );
+                            )
+                        }}
+                        options={{
+                            reload: () => {
+                                refetch()
+                            },
                         }}
                         toolbar={{
                             search: {
                                 onSearch: (value: string) => {
-                                    alert(value)
+                                    setSearch({ name: value })
                                 },
                             },
-                            onSearch: (value) => {
-                                console.log('value', value)
-                            },
                             actions: [
-
                                 <Button
                                         key="button"
                                         icon={<PlusOutlined/>}
                                         onClick={() => {
-                                            actionRef.current?.reload()
+                                            form.resetFields()
+                                            form.setFieldsValue({
+                                                id: 0,
+                                            })
+                                            setOpen(true)
                                         }}
                                         type="primary"
                                 >
@@ -96,10 +162,13 @@ const Roles = () => {
                         }}
                         pagination={{
                             total: data?.total,
-                            current: data?.page,
-                            pageSize: data?.pageSize,
+                            current: page.page,
+                            pageSize: page.pageSize,
                             onChange: (page) => {
-                                console.log('page', page)
+
+                                setPage((prev) => {
+                                    return { ...prev, page }
+                                })
                             }
                         }}
                 />
@@ -117,10 +186,14 @@ const Roles = () => {
                             maskClosable: false,
                         }}
                         onOpenChange={(open) => {
-                            console.log('open', open)
                             setOpen(open)
                         }}
-                        columns={columns} />
+                        loading={isPending}
+                        onFinish={(values) => {
+                            // console.log('values', values)
+                            return mutate(values)
+                        }}
+                        columns={columns}/>
             </PageContainer>
     )
 }
diff --git a/src/pages/system/roles/store.ts b/src/pages/system/roles/store.ts
index 336adc1..2dfdacf 100644
--- a/src/pages/system/roles/store.ts
+++ b/src/pages/system/roles/store.ts
@@ -1,8 +1,10 @@
 import { atom } from 'jotai/index'
 import { IRole } from '@/types/roles'
-import { atomWithQuery } from 'jotai-tanstack-query'
-import { IPage, IPageResult } from '@/types'
+import { atomWithMutation, atomWithQuery, queryClientAtom } from 'jotai-tanstack-query'
+import { IApiResult, IPage, IPageResult } from '@/types'
 import systemServ from '@/service/system.ts'
+import { message } from 'antd'
+import { t } from '@/i18n.ts'
 
 type SearchParams = IPage & IRole
 
@@ -14,6 +16,10 @@ export const roleAtom = atom<IRole>(undefined as unknown as IRole)
 
 export const searchAtom = atom<SearchParams>({} as SearchParams)
 
+export const pageAtom = atom<IPage>({
+    pageSize: 10,
+    page: 1,
+})
 
 export const rolesAtom = atomWithQuery<any, IPageResult<IRole>>((get) => {
     return {
@@ -22,4 +28,30 @@ export const rolesAtom = atomWithQuery<any, IPageResult<IRole>>((get) => {
             return await systemServ.role.list(params as SearchParams)
         },
     }
-})
\ No newline at end of file
+})
+
+//saveOrUpdateRoleAtom
+
+export const saveOrUpdateRoleAtom = atomWithMutation<IApiResult<IRole>>((get) => {
+
+    return {
+        mutationKey: [ 'updateMenu' ],
+        mutationFn: async (data: IRole) => {
+            if (data.id === 0) {
+                return await systemServ.menus.add(data)
+            }
+            return await systemServ.menus.update(data)
+        },
+        onSuccess: (res) => {
+            const isAdd = !!res.data?.id
+            message.success(t(isAdd ? 'message.saveSuccess' : 'message.editSuccess', '保存成功'))
+
+            //更新列表
+            // eslint-disable-next-line @typescript-eslint/ban-ts-comment
+            // @ts-ignore fix
+            get(queryClientAtom).invalidateQueries([ 'roles', get(searchAtom) ]).then()
+
+            return res
+        }
+    }
+})
diff --git a/src/types/roles.d.ts b/src/types/roles.d.ts
index 2f9efc0..cb6a9f3 100644
--- a/src/types/roles.d.ts
+++ b/src/types/roles.d.ts
@@ -1,5 +1,6 @@
 
 export interface IRole {
+    id: number,
     sort: number,
     code: string,
     name: string,
diff --git a/src/utils/tree.ts b/src/utils/tree.ts
new file mode 100644
index 0000000..e37872f
--- /dev/null
+++ b/src/utils/tree.ts
@@ -0,0 +1,54 @@
+type TreeKey = string | number;
+
+interface TreeNode {
+    key: TreeKey;
+    id?: TreeKey;
+    children?: TreeNode[];
+}
+
+export function getTreeCheckedStatus(tree: TreeNode[], selectKeys: TreeKey[]): { checked: TreeKey[], halfChecked: TreeKey[] } {
+    const checked: TreeKey[] = []
+    const halfChecked: TreeKey[] = []
+
+    if (!tree || tree.length === 0) return { checked, halfChecked }
+    if (!selectKeys || selectKeys.length === 0) return { checked, halfChecked }
+
+    // 辅助函数来递归地检查每个节点
+    function checkNode(node: TreeNode, ancestors: TreeKey[]): void {
+        const key = node.key ?? node.id
+        const isLeaf = !node.children || node.children.length === 0
+        const isSelected = selectKeys.includes(key)
+
+        // 如果是叶节点并且被选中，则直接加入到checked数组
+        if (isLeaf && isSelected) {
+            checked.push(key)
+            // 标记所有祖先为半选状态，除非它们已经被完全选中
+            ancestors.forEach(ancestorKey => {
+                if (!halfChecked.includes(ancestorKey) && !checked.includes(ancestorKey)) {
+                    halfChecked.push(ancestorKey)
+                }
+            })
+            return
+        }
+
+        // 非叶节点，递归检查其子节点
+        if (node.children) {
+            const childAncestors = [ ...ancestors, key ]
+            node.children.forEach(child => checkNode(child, childAncestors))
+
+            // 检查当前节点的所有子节点是否全部或部分被选中
+            const childSelectedCount = node.children.filter(child => checked.includes(child.key ?? child.id)).length
+            if (childSelectedCount === node.children.length) {
+                // 如果所有子节点都被选中，将当前节点标为全选
+                checked.push(key)
+            } else if (childSelectedCount > 0) {
+                // 如果部分子节点被选中，将当前节点标为半选
+                halfChecked.push(key)
+            }
+        }
+    }
+
+    // 遍历每一个根节点
+    tree.forEach(node => checkNode(node, []))
+    return { checked, halfChecked }
+}